-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[java] [spring] Fix annotationLibrary option being ignored in spring generator #22046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[java] [spring] Fix annotationLibrary option being ignored in spring generator #22046
Conversation
9298110
to
b2fe2ce
Compare
d6aa280
to
73e3a94
Compare
78c154b
to
216d5b0
Compare
cc-ing the Java team @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg |
just not entirely sure why |
please resolve the merge conflicts when you've time |
no idea either. i'll take care of it. don't worry |
216d5b0
to
65e26ad
Compare
i have just rebased on top of |
@wing328 any thoughts? |
Addresses #22045 similarly to #21992
Only register the model annotation imports based on the
annotationLibrary
property (either from Swagger v1, Swagger v2 or none), as documented in Config Options section of the Java generator docs.Currently, Spring generator partially ignores the option, only removing the imports from Swagger V1, completely ignoring the
Schema
from by Swagger V2.This PR addresses the
annotationLibrary = none
case by removing the Swagger V2 import.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)"fixes #123"
present in the PR description)